Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update readme #1793

Merged
merged 10 commits into from
Mar 14, 2019
Merged

chore: update readme #1793

merged 10 commits into from
Mar 14, 2019

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Mar 3, 2019

We have had gin website and examples repo, so we should update gin README.md.

@javierprovecho the last thres TODO need you help, thanks!

@codecov
Copy link

codecov bot commented Mar 3, 2019

Codecov Report

Merging #1793 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1793   +/-   ##
=======================================
  Coverage   98.62%   98.62%           
=======================================
  Files          41       41           
  Lines        2113     2113           
=======================================
  Hits         2084     2084           
  Misses         18       18           
  Partials       11       11

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e526148...3272aa5. Read the comment docs.

@thinkerou thinkerou self-assigned this Mar 5, 2019
@thinkerou thinkerou added this to the 1.4 milestone Mar 5, 2019
@appleboy
Copy link
Member

appleboy commented Mar 5, 2019

maybe we should keep the content of table?

@thinkerou
Copy link
Member Author

@appleboy yes, I hope gin/README.md clear and point user to gin/examples and gin-gonic.com, do you think?

@thinkerou thinkerou changed the title [wip] chore: update readme chore: update readme Mar 5, 2019
@thinkerou
Copy link
Member Author

@appleboy @javierprovecho I have updated complete, please help me review, thanks!

Copy link
Member

@javierprovecho javierprovecho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thinkerou last three checks done! 👍

@appleboy
Copy link
Member

@thinkerou conflicts.

@thinkerou
Copy link
Member Author

@appleboy fix done! thanks!

@thinkerou thinkerou merged commit cab0749 into gin-gonic:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants