Relocate binding body tests #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Every test file should be related to a tested file. Remove useless tests.
thinkerou
reviewed
Oct 9, 2019
| "testing" | ||
|
|
||
| "github.com/stretchr/testify/assert" | ||
| "github.com/stretchr/testify/require" |
There was a problem hiding this comment.
Fixed, I've added that package in vendor file.
That package helps us to show an useful test output on error cases. In case when we see assert's message of err != nil, the message about field's value is not equals says nothing helpful.
Codecov Report
@@ Coverage Diff @@
## master #2086 +/- ##
=======================================
Coverage 98.92% 98.92%
=======================================
Files 40 40
Lines 2229 2229
=======================================
Hits 2205 2205
Misses 12 12
Partials 12 12Continue to review full report at Codecov.
|
thinkerou
approved these changes
Oct 10, 2019
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
* Relocate binding body tests Every test file should be related to a tested file. Remove useless tests. * Add github.com/stretchr/testify/require package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every test file should be related to a tested file.
Remove useless tests.