Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'errcheck' linter warnings #2093

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Conversation

vkd
Copy link
Contributor

@vkd vkd commented Oct 12, 2019

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2019

Codecov Report

Merging #2093 into master will decrease coverage by 0.08%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
- Coverage   98.92%   98.83%   -0.09%     
==========================================
  Files          40       40              
  Lines        2229     2231       +2     
==========================================
  Hits         2205     2205              
- Misses         12       13       +1     
- Partials       12       13       +1
Impacted Files Coverage Δ
gin.go 98.28% <33.33%> (-0.86%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1bfcf...5b32b4a. Read the comment docs.

@thinkerou thinkerou added this to the 1.5 milestone Oct 27, 2019
@thinkerou thinkerou merged commit 393a63f into gin-gonic:master Oct 27, 2019
@vkd vkd deleted the fix-linter-warnings branch October 27, 2019 08:16
@Dominik-K
Copy link

Dominik-K commented Nov 1, 2019

@vkd Which (meta-)linter are you using? It seems that it didn't find that the error for os.Remove() isn't checked (in RunUnix()), as well.

@vkd
Copy link
Contributor Author

vkd commented Nov 1, 2019

@Dominik-K I use the golangci-lint

ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants