Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Custom Validators" example #2186

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Fix "Custom Validators" example #2186

merged 2 commits into from
Dec 18, 2019

Conversation

mosdeo
Copy link
Contributor

@mosdeo mosdeo commented Dec 16, 2019

  • Update fixed code.
  • Fix incorrect date for testing & demo.

Original testing date incompatible demo require, can't get expect result.
check_in date need NOT AFTER check_out date.
@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #2186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2186   +/-   ##
=======================================
  Coverage   98.49%   98.49%           
=======================================
  Files          40       40           
  Lines        2257     2257           
=======================================
  Hits         2223     2223           
  Misses         18       18           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 168fa94...c0ba35c. Read the comment docs.

@thinkerou thinkerou self-requested a review December 18, 2019 01:44
@thinkerou thinkerou added this to the 1.6 milestone Dec 18, 2019
@thinkerou thinkerou merged commit aee83e0 into gin-gonic:master Dec 18, 2019
thinkerou pushed a commit that referenced this pull request Dec 18, 2019
Excuse me, I forgot change output in #2186
thinkerou pushed a commit to gin-gonic/website that referenced this pull request Dec 18, 2019
Update fixed 500 err and incorrect testing date & output in demo.
- gin-gonic/gin#2186
- gin-gonic/examples#25
@thinkerou
Copy link
Member

@mosdeo sorry, now the master branch have upgraded to v10 not v9, please re-commit the pull request to fix it, thanks!

@mosdeo
Copy link
Contributor Author

mosdeo commented Dec 19, 2019

@mosdeo sorry, now the master branch have upgraded to v10 not v9, please re-commit the pull request to fix it, thanks!

I tried it few minutes ago, change to v10 have nothing different, I will modify it from repository "gin-gonic/examples".

ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* Update fixed error code from merged commit

According to [this](gin-gonic/examples@874dcfa) merged commit.

* Fixed incorrect testing date.

Original testing date incompatible demo require, can't get expect result.
check_in date need NOT AFTER check_out date.
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants