Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix accept incoming network connections #2216

Merged
merged 3 commits into from
Mar 7, 2020
Merged

fix accept incoming network connections #2216

merged 3 commits into from
Mar 7, 2020

Conversation

keob
Copy link
Contributor

@keob keob commented Jan 22, 2020

Suggest:

  • Turn off Pop-up prompt of accept incoming network connections on mac os.
  • Allow apps to communicate through windows defender firewall as default.

@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited
Loading

Codecov Report

Merging #2216 into master will decrease coverage by 0.12%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2216      +/-   ##
==========================================
- Coverage   98.51%   98.38%   -0.13%     
==========================================
  Files          41       41              
  Lines        2287     2290       +3     
==========================================
  Hits         2253     2253              
- Misses         18       21       +3     
  Partials       16       16
Impacted Files Coverage Δ
path.go 100% <ø> (ø) ⬆️
context.go 98.01% <0%> (-0.66%) ⬇️
tree.go 99.13% <100%> (-0.01%) ⬇️
render/json.go 87.8% <100%> (+0.3%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9eaf387...da350d1. Read the comment docs.

@thinkerou thinkerou added this to the 1.6 milestone Feb 27, 2020
thinkerou
thinkerou approved these changes Feb 28, 2020
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@appleboy appleboy merged commit 2ff2b19 into gin-gonic:master Mar 7, 2020
@keob keob deleted the fix-net-allow branch March 7, 2020 01:24
pull bot pushed a commit to scope-demo/gin that referenced this pull request Mar 7, 2020
@pull
fix accept incoming network connections (gin-gonic#2216)
350b133
@appleboy appleboy added the bug label Mar 22, 2020
@appleboy appleboy mentioned this pull request Mar 23, 2020
Closed
@appleboy
Copy link
Member

@keob maybe we should revert this PR. cc @thinkerou

appleboy added a commit that referenced this pull request Mar 23, 2020
@appleboy
Revert "fix accept incoming network connections (#2216)"
e8e308d 
This reverts commit 2ff2b19.
@appleboy appleboy mentioned this pull request Mar 23, 2020
Merged
@keob keob restored the fix-net-allow branch March 23, 2020 07:36
@keob keob deleted the fix-net-allow branch March 23, 2020 07:39
This was referenced Mar 23, 2020
Closed
Closed
thinkerou pushed a commit that referenced this pull request Mar 23, 2020
@appleboy
Revert "fix accept incoming network connections (#2216)" (#2294)
1bebd9a 
This reverts commit 2ff2b19.
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
@byebyebruce
fix accept incoming network connections (gin-gonic#2216)
91592c5
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
@appleboy @byebyebruce
Revert "fix accept incoming network connections (gin-gonic#2216)" (gi…
2dad9d5 
…n-gonic#2294)

This reverts commit 2ff2b19.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.
3 participants
@keob @appleboy @thinkerou