Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement ".Unwrap() error" on Error type (#2525) #2526

Merged
merged 4 commits into from
Oct 17, 2020
Merged

implement ".Unwrap() error" on Error type (#2525) #2526

merged 4 commits into from
Oct 17, 2020

Conversation

LeGEC
Copy link
Contributor

@LeGEC LeGEC commented Oct 9, 2020 •
edited
Loading

Implement .Unwrap() error method on type Error, to be compatible with stdlib errors.Is() and erors.As() functions.

@codecov
Copy link

codecov bot commented Oct 9, 2020 •
edited
Loading

Codecov Report

Merging #2526 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2526   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          41       41           
  Lines        1951     1952    +1     
=======================================
+ Hits         1921     1922    +1     
  Misses         17       17           
  Partials       13       13
Impacted Files Coverage Δ
errors.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c83a1cc...41c0dff. Read the comment docs.

appleboy
appleboy previously approved these changes Oct 14, 2020
View reviewed changes
@appleboy appleboy added this to the 1.7 milestone Oct 14, 2020
thinkerou
thinkerou approved these changes Oct 17, 2020
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thinkerou thinkerou merged commit f969bfa into gin-gonic:master Oct 17, 2020
@thinkerou thinkerou mentioned this pull request Oct 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
feature
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@LeGEC @appleboy @thinkerou