Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve router group tests #2787

Merged
merged 1 commit into from
Jul 13, 2021
Merged

Improve router group tests #2787

merged 1 commit into from
Jul 13, 2021

Conversation

zihengCat
Copy link
Contributor

@zihengCat zihengCat commented Jul 12, 2021 •
edited
Loading

  • Use relative value instead of hard coded number in TestRouterGroupTooManyHandlers.
  • Also check the panic value in test.

@codecov
Copy link

codecov bot commented Jul 12, 2021 •
edited
Loading

Codecov Report

Merging #2787 (05ffa84) into master (f96678c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2787   +/-   ##
=======================================
  Coverage   98.70%   98.70%           
=======================================
  Files          41       41           
  Lines        2085     2085           
=======================================
  Hits         2058     2058           
  Misses         15       15           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f96678c...05ffa84. Read the comment docs.

@zihengCat
Copy link
Contributor Author

@appleboy @thinkerou

@appleboy appleboy added the test label Jul 13, 2021
@appleboy appleboy added this to the v1.8 milestone Jul 13, 2021
@appleboy appleboy merged commit caf2802 into gin-gonic:master Jul 13, 2021
daheige pushed a commit to daheige/gin that referenced this pull request Apr 18, 2022
@zihengCat @daheige
Improve router group tests (gin-gonic#2787)
9e86dd1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daheige daheige daheige approved these changes

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
v1.8
Development

Successfully merging this pull request may close these issues.
3 participants
@zihengCat @appleboy @daheige