-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tidy: Complete TrustedProxies feature #2887
Conversation
Also hope you guys to help #2844 with code review. |
Codecov Report
@@ Coverage Diff @@
## master #2887 +/- ##
=======================================
Coverage 98.75% 98.76%
=======================================
Files 41 41
Lines 3063 3065 +2
=======================================
+ Hits 3025 3027 +2
Misses 26 26
Partials 12 12
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Hello, help with code review please. |
This PR should be merge to v1.7.5 cc @thinkerou |
@appleboy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@appleboy Hi, this PR can be merged. |
(cherry picked from commit 3918132)
(cherry picked from commit 3918132)
(cherry picked from commit 3918132)
(cherry picked from commit 3918132)
(cherry picked from commit 3918132)
@thinkerou @appleboy
Was a breaking change, and should not have been merged in a patch version. It did break people's code. See https://go.dev/blog/v2-go-modules :
|
Background
Related issues: #2814 #2697 #2819
Related pull requests: #2832 #2692
About #2692 :
#2692 (comment) by @leafduo
What I do
So I did these things below in this PR:
Engine.TrustedProxies
private, force people to useEngine.SetTrustedProxies()
to set proxies.Run
,RunTLS
, etc.This PR should be published with #2692 .