Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds cookie binding #3393

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

sourcec0de
Copy link

@sourcec0de sourcec0de commented Nov 12, 2022

Hey all, 👋
Here's a simple addition for binding cookies.
I've seen this a few times in closed PRs #2805 & #2812.
Seems like they decided to move to their own repo for other reasons.

  • With pull requests:
    • Open your pull request against master
    • Your pull request should have no more than two commits, if not you should squash them.
    • It should pass all tests in the available continuous integration systems such as GitHub Actions.
    • You should add/modify tests to cover your proposed code changes.
    • If your pull request contains a new feature, please document it on the README.

@sourcec0de
Copy link
Author

sourcec0de commented Nov 12, 2022

I'm new, so it looks like I need a maintainer to approve my tests 😁

@appleboy, @thinkerou, @javierprovecho any thoughts on this PR?

@appleboy appleboy added this to the v1.9 milestone Nov 17, 2022
@appleboy
Copy link
Member

appleboy commented Jan 2, 2023

@sourcec0de Please help to resolve the conflicts.

@sourcec0de
Copy link
Author

@appleboy I'll have time to check this out tomorrow.
Looks like simple conflicts in the README.

@appleboy
Copy link
Member

appleboy commented Jan 7, 2023

@sourcec0de Yes. we refine the readme structure. See the PR #3449

@thinkerou thinkerou modified the milestones: v1.9, v1.10 Jan 17, 2023
@sourcec0de
Copy link
Author

@appleboy I've updated my branch and resolved the conflict with the README.

@appleboy appleboy modified the milestones: v1.10, v1.9 Feb 13, 2023
appleboy
appleboy previously approved these changes Feb 13, 2023
@appleboy
Copy link
Member

@thinkerou help to review.

@appleboy
Copy link
Member

@sourcec0de Please help to fix the testing.

@thinkerou thinkerou modified the milestones: v1.9, v1.10 Feb 14, 2023
@appleboy
Copy link
Member

build fail. move to 1.11

@appleboy appleboy modified the milestones: v1.10, v1.11 Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants