Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin reuse version to 2.1.0 #1591

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Pin reuse version to 2.1.0 #1591

merged 1 commit into from
Apr 4, 2024

Conversation

pratikvn
Copy link
Member

@pratikvn pratikvn commented Apr 4, 2024

This PR fixes issue #1590

Closes #1590

@pratikvn @MarcelKoch
Pin reuse version to 2.1.0
dec10b9 
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
@pratikvn pratikvn added reg:ci-cd This is related to the continuous integration system. 1:ST:ready-for-review This PR is ready for review is:bugfix This fixes a bug 1:ST:skip-full-test 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Apr 4, 2024
@pratikvn pratikvn requested a review from MarcelKoch April 4, 2024 11:59
@pratikvn pratikvn self-assigned this Apr 4, 2024
@pratikvn pratikvn requested a review from a team April 4, 2024 11:59
upsj
upsj approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@upsj upsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Can you reference a corresponding issue in the Reuse repository? Or do they not intend to fix the underlying behavior?

@MarcelKoch
Copy link
Member

@upsj here is a PR in their repo: fsfe/reuse-tool#909

@pratikvn pratikvn added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Apr 4, 2024
@pratikvn pratikvn merged commit 9bd8c0d into develop Apr 4, 2024
11 of 15 checks passed
@pratikvn pratikvn deleted the reuse-pin-210 branch April 4, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@upsj upsj upsj approved these changes

@yhmtsai yhmtsai yhmtsai approved these changes

@MarcelKoch MarcelKoch Awaiting requested review from MarcelKoch

Assignees

@pratikvn pratikvn

Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test is:bugfix This fixes a bug reg:ci-cd This is related to the continuous integration system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Newer reuse versions do not recognize .inc extensions
4 participants
@pratikvn @MarcelKoch @upsj @yhmtsai