Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean unused sycl version switch and change the badge #1702

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

yhmtsai
Copy link
Member

@yhmtsai yhmtsai commented Oct 18, 2024

We support oneapi from 2023.1, whose __LIBSYCL_MAJOR_VERSION is already 6 (6.1.0 for __LIBSYCL).
This PR delete the dispatch before 6.
Also, change the c++14 badge to c++17 badge

@yhmtsai yhmtsai added 1:ST:ready-for-review This PR is ready for review 1:ST:no-changelog-entry Skip the wiki check for changelog update labels Oct 18, 2024
@yhmtsai yhmtsai requested a review from a team October 18, 2024 08:37
@yhmtsai yhmtsai self-assigned this Oct 18, 2024
@ginkgo-bot ginkgo-bot added reg:documentation This is related to documentation. mod:core This is related to the core module. mod:dpcpp This is related to the DPC++ module. labels Oct 18, 2024
@yhmtsai yhmtsai changed the title clear unused sycl version switch and change the badge clean unused sycl version switch and change the badge Oct 18, 2024
@yhmtsai yhmtsai added 1:ST:ready-to-merge This PR is ready to merge. and removed 1:ST:ready-for-review This PR is ready for review labels Oct 21, 2024
@yhmtsai yhmtsai merged commit a521e1d into develop Oct 22, 2024
9 of 11 checks passed
@yhmtsai yhmtsai deleted the clear_sycl branch October 22, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1:ST:no-changelog-entry Skip the wiki check for changelog update 1:ST:ready-to-merge This PR is ready to merge. 1:ST:skip-full-test mod:core This is related to the core module. mod:dpcpp This is related to the DPC++ module. reg:documentation This is related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants