Half base type #1706
Open
Half base type #1706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ginkgo-bot
added
reg:build
yhmtsai
force-pushed
the
half_type
branch
2 times, most recently
from
265cb47
to
b0c488b
Compare
yhmtsai
added
1:ST:WIP
yhmtsai
force-pushed
the
half_type
branch
4 times, most recently
from
8bd8d1c
to
2ab1acd
Compare
yhmtsai
added
1:ST:ready-for-review
MarcelKoch
approved these changes
Oct 24, 2024
|
@MarcelKoch I have made the half without types.hpp dependence such that we can include it directly without circular dependence and the instantiate function have the definition of half now |
MarcelKoch
approved these changes
Oct 24, 2024
This was referenced Oct 24, 2024
MarcelKoch
requested changes
Oct 28, 2024
yhmtsai
force-pushed
the
half_type
branch
2 times, most recently
from
bfbe44b
to
0c24e81
Compare
MarcelKoch
approved these changes
Oct 30, 2024
… half to another test
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Co-authored-by: Marcel Koch <marcel.koch@kit.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr moves the half out of extended_float.hpp with some modification and half is available in the public interface.
Currently, we can still mark some conversion/operation with GKO_ATTRIBUTE and GKO_INLINE.
However, I think it is good to ensure we only use the vendor's impl on device side.
To achieve it, Jacobi needs to use __half not half now.
This also removes the undefined behavior from
reinterpret_casttostd::memcpyone question: should we mark the half precision in experimental namespace?in usual interface from discussion