Fix/mapper colors

[lewtun]

Reference Issues/PRs

Fixes #266

What does this implement/fix? Explain your changes.

• Normalises node_colors values to lie in range [0,1]
• Reuses plot_point_cloud function from examples/ for Mapper quickstart notebook

Any other comments?

[lewtun]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[wreise]

Please clarify the comment on indentation. Reducing indentation produces the desired behavior on the us-election use case.

[wreise]

I believe that this block is too indented and is executed only when not is_node_colors_ndarray, while I believe it should always be.

Same question for the above: should we get_node_summary only in the else case?

[lewtun]

Good catch - thanks! I've fixed the indentation in cc2d646

Regarding get_node_summary it is correct to only call it in the else case as we distinguish between scenarios where the user passes an ndarray vs [callable, transformer, etc]. In the latter case we define color_data which is then used by get_node_summary to calculate node_colors

[wreise]

thanks for clarifying!

[lewtun]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[lewtun]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[wreise]

Pipelines fail due to [IPKernelApp] WARNING | Parent appears to have exited, shutting down "papermill". Have we seen this before?
Some relevant issues:
1.
2.

[ulupo]

Hmm, no idea @wreise, this has never come up before. Maybe a freak accident and we can try rerunning?

[wreise]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).