Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix requiresAuthentication for null user identity #557

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix requiresAuthentication for null user identity #557

merged 2 commits into from
Feb 22, 2024

Conversation

rslopes
Copy link
Contributor

@rslopes rslopes commented Sep 1, 2023 •
edited
Loading

Description

With this PR, I'm adding a validation to prevent requiresAuthentication from throwing NullReferenceException when the user.Identity is null.

How to test

Related issues

@rslopes rslopes marked this pull request as ready for review September 1, 2023 19:49
@rslopes rslopes changed the title fix: null identity Fix requiresAuthentication for null user identity Sep 1, 2023
@rslopes rslopes changed the base branch from master to develop September 1, 2023 19:53
@64J0 64J0 merged commit 9f888b0 into giraffe-fsharp:develop Feb 22, 2024
5 checks passed
@64J0 64J0 mentioned this pull request Feb 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@64J0 64J0 64J0 approved these changes

@Lanayx Lanayx Lanayx approved these changes

@TheAngryByrd TheAngryByrd TheAngryByrd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullReferenceException in requiresAuthentication funciton
4 participants
@rslopes @TheAngryByrd @Lanayx @64J0