[Synapse] - Add missing API version parameter (Azure#11751)

* [Synapse] - Add missing API version parameter and pageable * Fix lint * Fix recent found issues * Fix lint error * Fix model validation errors * Remove x-ms-pageable * Rename Action to RequiredAction * Revert x-ms-pageable and AccessDecisions * Update description for AccessDecisions * Update checkAccessSynapseRbac.json Slight wording fix Co-authored-by: Dongwei Wang <dongwwa@microsoft.com> Co-authored-by: Jonathan Turner <jonathandturner@users.noreply.github.com>
giromm2ms · Dec 20, 2020 · 1a81dfb · 1a81dfb
1 parent 1909492
commit 1a81dfb
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 29 deletions.
diff --git a/...napse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/checkAccessSynapseRbac.json b/...napse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/checkAccessSynapseRbac.json
@@ -22,7 +22,7 @@
         "tags": [
           "CheckPrincipalAccess"
         ],
-        "operationId": "CheckPrincipalAccess",
+        "operationId": "RoleAssignments_CheckPrincipalAccess",
         "description": "Check if the given principalId has access to perform list of actions at a given scope.",
         "x-ms-examples": {
           "Check access": {
@@ -141,7 +141,7 @@
           "description": "List of actions.",
           "type": "array",
           "items": {
-            "$ref": "#/definitions/Action"
+            "$ref": "#/definitions/RequiredAction"
           }
         },
         "scope": {
@@ -150,7 +150,7 @@
         }
       }
     },
-    "Action": {
+    "RequiredAction": {
       "description": "Action Info",
       "type": "object",
       "required": [
@@ -170,9 +170,15 @@
     },
     "CheckPrincipalAccessResponse": {
       "description": "Check access response details",
-      "type": "array",
-      "items": {
-        "$ref": "#/definitions/CheckAccessDecision"
+      "type": "object",
+      "properties": {
+        "AccessDecisions": {
+          "description": "To check if the current user, group, or service principal has permission to read artifacts in the specified workspace.",
+          "type": "array",
+          "items": {
+            "$ref": "#/definitions/CheckAccessDecision"
+          }
+        }
       }
     },
     "SubjectInfo": {

diff --git a/...a-plane/Microsoft.Synapse/preview/2020-08-01-preview/examples/CheckAccessSynapseRbac.json b/...a-plane/Microsoft.Synapse/preview/2020-08-01-preview/examples/CheckAccessSynapseRbac.json
@@ -25,30 +25,32 @@
   },
   "responses": {
     "200": {
-      "body": [
-        {
-          "accessDecision": "Allowed || NotAllowed",
-          "actionId": "Action 1",
-          "roleAssignment": {
-            "id": "00000000-0000-0000-0000-000000000000",
-            "roleDefinitionId": "00000000-0000-0000-0000-000000000000",
-            "principalId": "00000000-0000-0000-0000-000000000000",
-            "scope": "workspaces/exampleWorkspace",
-            "principalType": "User || Group || ServicePrincipal"
-          }
-        },
-        {
-          "accessDecision": "Allowed || NotAllowed",
-          "actionId": "Action 1",
-          "roleAssignment": {
-            "id": "00000000-0000-0000-0000-000000000000",
-            "roleDefinitionId": "00000000-0000-0000-0000-000000000000",
-            "principalId": "00000000-0000-0000-0000-000000000000",
-            "scope": "workspaces/exampleWorkspace",
-            "principalType": "User || Group || ServicePrincipal"
+      "body": {
+        "accessDecisions": [
+          {
+            "accessDecision": "Allowed || NotAllowed",
+            "actionId": "Action 1",
+            "roleAssignment": {
+              "id": "00000000-0000-0000-0000-000000000000",
+              "roleDefinitionId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000",
+              "scope": "workspaces/exampleWorkspace",
+              "principalType": "User || Group || ServicePrincipal"
+            }
+          },
+          {
+            "accessDecision": "Allowed || NotAllowed",
+            "actionId": "Action 1",
+            "roleAssignment": {
+              "id": "00000000-0000-0000-0000-000000000000",
+              "roleDefinitionId": "00000000-0000-0000-0000-000000000000",
+              "principalId": "00000000-0000-0000-0000-000000000000",
+              "scope": "workspaces/exampleWorkspace",
+              "principalType": "User || Group || ServicePrincipal"
+            }
           }
-        }
-      ]
+        ]
+      }
     },
     "default": {
       "body": {

diff --git a/...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleAssignments.json b/...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleAssignments.json
@@ -187,6 +187,9 @@
           },
           {
             "$ref": "#/parameters/RoleAssignmentIdParameter"
+          },
+          {
+            "$ref": "#/parameters/ScopeParameter"
           }
         ],
         "responses": {

diff --git a/...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleDefinitions.json b/...tion/synapse/data-plane/Microsoft.Synapse/preview/2020-08-01-preview/roleDefinitions.json
@@ -79,6 +79,9 @@
           "text/json"
         ],
         "parameters": [
+          {
+            "$ref": "#/parameters/ApiVersionParameter"
+          },
           {
             "$ref": "#/parameters/RoleDefinitionIdParameter"
           }
-Original file line number
+Diff line change
@@ Expand Up / @@ -187,6 +187,9 @@ @@
               },
               {
                 "$ref": "#/parameters/RoleAssignmentIdParameter"
+              },
+              {
+                "$ref": "#/parameters/ScopeParameter"
               }
             ],
             "responses": {
@@ Expand Down @@