installer: Update Inno Setup from 5.6.1 to 6.1.2 #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no longer a separate is-unicode.exe file for InnoSetup - only is.exe is available now. Details can be found at https://jrsoftware.org/isdl.php#stable. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
Previously, there was a separate is-unicode.exe version of InnoSetup. Starting with version 6, only an is.exe file is available. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
This commit is the exact output of running installer/update-inno-setup.sh, without any other changes. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
This commit applies several changes to install.iss that are necessary after the Inno Setup 6.1.0 update. Signed-off-by: Dennis Ameling <dennis@dennisameling.com>
dennisameling
commented
Mar 2, 2021
| ErrorCode:Integer; | ||
| begin | ||
| GetWindowsVersionEx(Version); | ||
| if (Version.Major<6) then begin |
There was a problem hiding this comment.
As discussed in #327 (comment), this check is no longer necessary since the minimum version required by InnoSetup is now also Windows Vista (see MinVersion above).
dennisameling
commented
Mar 2, 2021
| @@ -3370,7 +3362,6 @@ begin | |||
| Form.Caption:='Git Uninstall: Removing in-use files'; | |||
| Form.ClientWidth:=ScaleX(500); | |||
| Form.ClientHeight:=ScaleY(256); | |||
| Form.Center; | |||
There was a problem hiding this comment.
Needed to prevent errors in InnoSetup, as discussed in #327 (comment)
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successor of #327. As discussed in that PR, we'll make separate PRs for the Inno Setup update and later on for adding Windows ARM64 64-bit support (currently installs in
Program Files (x86)). This PR focuses on the Inno Setup upgrade, without changing any other functionality. It's split up into multiple commits for easier reviewing.CC @dscho