installer: skip Experimental Options page, if empty #578
Conversation
installer/install.iss
Outdated
| @@ -423,6 +423,7 @@ const | |||
| GP_BuiltinAddI = 4; | |||
| GP_EnablePCon = 5; | |||
| GP_EnableFSMonitor = 6; | |||
| GP_Max = 6; | |||
There was a problem hiding this comment.
This is a great idea, but the name is slightly confusing since we use the same GP_ prefix for other things.
There was a problem hiding this comment.
I revamped this rather completely. Could you have another look, @rimrul?
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
For drop-down and radio button options, we used to manually pick the largest value when defining the size of the corresponding array. Let's instead introduce consistent `..._Max...` constants for this purpose. This will make the next commit cleaner, where we need to iterate over all experimental options. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
As of a75602a (installer: hide the "experimental" FSMonitor setting by default, 2024-07-17), the FSMonitor option is hidden from the options page unless the user had enabled it previously. However, this then left the page blank (or: all options hidden), not a good user experience. So let's skip it if it would appear blank. This fixes git-for-windows/git#5231. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
…xperimental option If all of the experimental options are hidden, we skip that page. However, this is the last page of the wizard (at least if there are no active processes that would block the installation), and that is therefore the page where we re-label the "Next" button so that it says "Install". Therefore, if the experimental options page is hidden, we need to move that button re-labeling to the preceding page. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
avoid-empty-experimental-options-page
branch
from
70911c3 to
18e1a8d
Compare
|
/add relnote bug Due to a bug introduced in the v2.47 cycle, the installer showed an empty "experimental options" page, which was fixed. The workflow run was started |
Due to a bug introduced in the v2.47 cycle, [the installer showed an empty "experimental options" page](git-for-windows/git#5231), which was [fixed](#578). Signed-off-by: gitforwindowshelper[bot] <gitforwindowshelper-bot@users.noreply.github.com>
Yes, this indeed need to improve user experience of the last page. As for all, This does not effect the installation process or nothing wrong with the installation as you can go ahead and just hit the "Install" button and installation will begin. Though, at some point in the future, this (user experience) needs to be address. As for enabling experimental options, I would assume the user set |
@jerryfleurival I don't understand... Do you mean to say that this is not fixed for you? For me, the last page is:
After that, I only get the following page if I have a Git Bash open, otherwise it immediately starts to install Git for Windows:
At no point do I see an empty "Experimental Options" page. Is this different for you? |
|
@dscho I'm on version 2.47.0.2. I left those two unchecked, and then came a blank Experimental Options page. |
Well, the fix is in v2.47.1, that's why you don't have it. You need to upgrade. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
As of a75602a (installer: hide the "experimental" FSMonitor setting by default, 2024-07-17), the FSMonitor option is hidden from the options page unless the user had enabled it previously.
However, this then left the page blank (or: all options hidden), not a good user experience. So let's skip it if it would appear blank.
This fixes git-for-windows/git#5231.