t: avoid incorrect negated commands #5282
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
set -e
is enabled, not all commands trigger an error exit if they return false. For example, it's clear that commands in anif
orwhile
statement don't cause an error if they are false.What is less obvious, however, is that negated commands and negated pipelines also have no effect on
set -e
. From POSIX 1003.1-2017 (onsh -e
):As such, writing something like
! grep
will never fail. Fortunately, we can append&& exit 1
instead of the!
and that will work correctly.To make this work, run the following command to make the code properly check the exit status of our commands:
Fixes #5183