Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Links to files in subdirectories broken in Markdown files #1358

Closed
flaix opened this issue Nov 9, 2020 · 1 comment
Closed

Links to files in subdirectories broken in Markdown files #1358

flaix opened this issue Nov 9, 2020 · 1 comment
Labels
🐱 Defect Status-Fixed
Milestone
1.9.2

Comments

@flaix
Copy link
Member

flaix commented Nov 9, 2020

In a Markdown document a link to another document in a subfolder will not work. The path to the subfolder is not properly escaped in the link.

Readme.md:

This is [a link](sub/file.md) to a document in a sub folder.

Will not properly link to file sub/file.md.
@flaix flaix added Priority-Medium 🐱 Defect Status-Verified A bug could be reproduced. Status-Fixed and removed Priority-Medium Status-Verified A bug could be reproduced. labels Nov 9, 2020
@flaix flaix added this to the 1.9.2 milestone Nov 16, 2020
flaix added a commit to flaix/gitblit that referenced this issue Nov 16, 2020
@flaix
fix: Also parse exp links in MD pages
79400df 
Add a link parser also for `ExpLinks` because we need to escape paths
to files in subfolders.
This closes gitblit-org#1358
@flaix flaix closed this as completed in b23269a Nov 16, 2020
@TomaszSzt
Copy link
Contributor

Needs to be re-opened. The fix have broken absolute explicit links in MD files.

TomaszSzt added a commit to TomaszSzt/gitblit that referenced this issue Nov 17, 2021
@TomaszSzt
This commit fixes what was broken in commit
259b02f 
gitblit-org@b23269a
due to gitblit-org#1358 issue
@TomaszSzt TomaszSzt mentioned this issue Nov 17, 2021
Merged
flaix pushed a commit that referenced this issue Nov 18, 2021
@TomaszSzt
Fixes external links broken in markdown rendering (#1392)
ebbd27b 
* This commit fixes what was broken in commit
b23269a
due to #1358 issue
flaix added a commit that referenced this issue Dec 6, 2021
@flaix
pages: Fix repo-relative reference links in markdown docs
823a8fb 
As with explicit links, also for reference links in markdown documents
which point to repository-relative files the links are broken. They do
not take the path to the repository into account.
This fix is related to commit b23269 which fixed issue #1358
for explicit links.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐱 Defect Status-Fixed
Projects
None yet
Milestone
1.9.2
Development

No branches or pull requests
2 participants
@flaix @TomaszSzt