show blockexplorer url of transaction in email, retires old "x times" language in emails #8520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owocki
requested review from
chibie,
frankchen07,
gdixon,
octavioamu,
PixelantDesign and
thelostone-mc
as code owners
thelostone-mc
approved these changes
Mar 10, 2021
| if self.checkout_type == 'eth_std': | ||
| network_sub = f"{{self.subscription.network}}." if self.subscription and self.subscription.network != 'mainnet' else '' | ||
| return f'https://{network_sub}etherscan.io/tx/{self.split_tx_id}' | ||
| # TODO: support all block explorers for diff chains |
There was a problem hiding this comment.
@chibie we'll have to keep a track of this to update next week with all the chains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
show blockexplorer url of transaction in email, retires old "x times" language in emails
Refers/Fixes
common sense, self
Testing
tested locally https://share.getcloudapp.com/2NuED8wR