-
-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GITC-102: Hackathons landing page (developers) refresh #9304
Conversation
db951d0
to
11da59a
Compare
<div class="mt-3 font-smaller-2"> | ||
<div class="mb-1 text-grey-400">Sponsored by</div> | ||
{% for sponsor in event.sponsor_profiles|slice:":6" %} | ||
<a href="{{ sponsor.absolute_url }}" target="_blank"><img class="rounded-circle my-1 mr-1" style="width:36px;" src="{{ sponsor.avatar_url }}" /></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
worth adding noopener/noreferrer
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do, but these are internal links - they're pointing to the sponsors profile (this code is unchanged from the original hackathon-list.html
page)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but left one minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! I pulled it and tested locally too. I think it's good to move forward. We need to make sure the content at the HappyFox link is updated before we deploy (https://support.gitcoin.co/kb/article/81-hackathons-how-it-works)
some feedback. some is about design, some about implmenetation
|
We're pulling that image from http://stage.gitcoin.co/dynamic/avatar/cryptomental - for some reason the dynamic end-point on staging is failing and I've not had chance to dig into why yet (its likely because we don't have s3 connected and all of this data was copied from production without any of the assets). This works on both my local and on production (https://gitcoin.co/dynamic/avatar/cryptomental/) - I can have a look to get it going again tomorrow.
Ahhh, sorry about that, I hadn't ran the migrations - that should work now -- please note that I've placed the JSONstore manually to reflect the state of production, so some hackathons won't be present on staging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lookin' good!
Header
I'm noticing extra space between
Hey Hackers, go build cool stuff and Build a bunch of cool stuff, learn new tech, support the open source ecosystem, and earn cash and prizes!. Consider removing extra space. See mission page header spacing.
Sponsor Hackathon
Want to become a sponsor or run an exclusive hackathon on Gitcoin?
This feels like a system alert (less of a promotion), as it follows our system alert design.
How to Get Started
Could we consider switching the How to get started section and the Get the latest on Gitcoin email newsletter section?
Email Newsletter
Email newsletter section, when I entered my email, I didn't receive a confirmation message (see mission page newsletter module).
cc @willsputra
Since this page is more optimised for hackers, we want explore hackathons to be the primary CTA. We also wanted to provide a bit more context for funders that they can either be a sponsor or run exclusive hacks with us. We can update the design to make it more obvious tho (and not clash with our system design) as below cc @PixelantDesign
agree with these.
I'd still prefer putting the How to get started at the bottom so new users understand the what > why > how A couple more questions:
|
…nd hack-list indentation
This is resolved in b2e2acd
This is resolved in 3f09665
Nice catch @PixelantDesign - thats now resolved in b2e2acd
Yes, that will be picked up when it is filled in the backend, the data on staging was a duplicate of whats on production, and the field won't be available until this PR is deployed.
Yes, let's split this out into a separate ticket, we will have to have a think about how we curate that list to ensure all sponsors are highlighted fairly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
2804b25
to
6435b9a
Compare
This state shows when the hackathon event has reached an end but before the page cache has been regenerated (which would move the event in to the In the old design those buttons were removed, but because that would leave a lot of empty space, I opted to disable them instead. If someone from the team was to go in to the _admin panel, they would be able to trigger the cache to be regenerated manually (or we can wait for the cron to trigger the refresh (it runs once every 3 hours)). So this state is rare, but it does handle an edge-case (you cannot join a hackathon after it has ended). |
Got it! Then it looks good to me. |
<script src="https://cdn.jsdelivr.net/npm/perlin@1.0.0/index.min.js"></script> | ||
<script src="{% static "v2/js/lib/svgator_player.js" %}"></script> | ||
<script src="{% static "v2/js/bubbles.js" %}"></script> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
goood one
tabs = [ | ||
('current', 'happening now', num_current), | ||
('upcoming', 'upcoming', num_upcoming), | ||
('finished', 'completed', num_finished), | ||
] | ||
|
||
# shuffle the sponsors | ||
random.shuffle(sponsors) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Description
This PR implements the hackathons landing page refresh.
build design that includes:
Refers/Fixes
Fixes: GITC-102
Fixes: GITC-232
Testing
Tested locally