Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runs clr calcs more frequently (every 15 mins) #9446

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Conversation

gdixon
Copy link
Contributor

@gdixon gdixon commented Sep 7, 2021

Description

This PR updates the crontabs to run the clr calc more frequently (every 15 minutes)

Testing

Tested locally

Copy link
Contributor

@zlsgh zlsgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
When we deploy this, let's make sure to watch it for a few hours to make sure it's not taking longer than we expect after many runs.

@owocki
Copy link
Contributor

owocki commented Sep 8, 2021

note that i dont think the deploy script automatically installs crontab2 - crontab4 . youll need to install these manually on the celery boxes once merged in.

Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gdixon just for clarity, shouldn't the slim clr calc be more frequent than full clr calc?

@octavioamu octavioamu merged commit 0710678 into stable Sep 8, 2021
@gdixon
Copy link
Contributor Author

gdixon commented Sep 8, 2021

note that i dont think the deploy script automatically installs crontab2 - crontab4 . youll need to install these manually on the celery boxes once merged in.

I've got these installed 👍

@gdixon just for clarity, shouldn't the slim clr calc be more frequent than full clr calc?

Yes it should -- I think we can likely deprecate the slim calc now though because its only around 30secs faster than the full calc (when we run it against the end state of one of the gr10 clrs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants