adding tests for creating projects on portfolio page #9553
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksolo
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
added 7 commits
October 2, 2021 10:08
ksolo
force-pushed
the
gitc-304/add-a-project-race-condition
branch
from
0ca01d5
to
91fad02
Compare
thelostone-mc
approved these changes
Oct 4, 2021
chibie
reviewed
Oct 4, 2021
jeremyschuurmans
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ticket showed a case where you could add multiple instances of the same project to your portfolio page
/<username>/portfolio. The existing implementation did not protect against duplicates. This PR adds tests around the creation and a unique constraint over the profile, title, link fields.Refers/Fixes
Jira: GITC-304
Testing
Tests have been provided via pytest.