fix grants explorer #9559
Merged
fix grants explorer #9559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chibie
requested review from
frankchen07,
gdixon,
PixelantDesign,
thelostone-mc and
zlsgh
as code owners
ksolo
approved these changes
Oct 4, 2021
jeremyschuurmans
approved these changes
Oct 4, 2021
ksolo
reviewed
Oct 4, 2021
| @@ -51,7 +51,7 @@ def add_arguments(self, parser): | |||
|
|
|||
| def handle(self, *args, **options): | |||
|
|
|||
| _, round_start_date, round_end_date, _ = get_clr_rounds_metadata() | |||
| _, round_start_date, round_end_date, _, _, _, _, _ = get_clr_rounds_metadata() | |||
There was a problem hiding this comment.
@chibie This is a quick fix, but this method is extremely fragile. It feels like it should be returning an object, not a tuple that we can access data on without guessing how many and where the _ should go. I approve this so we can fix the deploy, but let's open a new tech debt ticket in Jira to fix this.
There was a problem hiding this comment.
@ksolo yea makes perfect sense
There was a problem hiding this comment.
Using a named tuple would likely provide enough of an abstraction to prevent these types of bugs - https://docs.python.org/3/library/collections.html#collections.namedtuple
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
grants explorer broke due get_clr_rounds_metadata update
Refers/Fixes
https://gitcoincore.slack.com/archives/CDML7FS7M/p1633365131046300
Testing