Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jeremy/GITC-460/inaccurate payout amount bug #9645

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

jeremyschuurmans
Copy link
Contributor

@jeremyschuurmans jeremyschuurmans commented Oct 29, 2021

Description

This PR resolves an issue where payout amounts were not being rendered correctly in cases where multiple payouts were made to different people on the same bounty.
Screen Shot 2021-11-03 at 2 42 34 PM

Refers/Fixes
Testing

This PR includes unit tests for successfully hitting the bounty API, and for making a successful payout. Tests specific to the bug will be addressed in a separate ticket due to the complexity of testing that behavior.

@jeremyschuurmans jeremyschuurmans changed the title Jeremy/gitc 460/inaccurate payout amount bug Jeremy/GITC-460/inaccurate payout amount bug Nov 3, 2021
@jeremyschuurmans jeremyschuurmans marked this pull request as ready for review November 3, 2021 14:22
Copy link
Contributor

@gdixon gdixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codewise this LGTM!! 🙌

Copy link
Contributor

@chibie chibie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@gdixon gdixon merged commit 3ff30b5 into master Nov 4, 2021
@jeremyschuurmans jeremyschuurmans deleted the jeremy/GITC-460/inaccurate-payout-amount-bug branch November 10, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants