Jeremy/GITC-565/fix Twitter handle feature #9661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
ksolo
suggested changes
Nov 3, 2021
ksolo
reviewed
Nov 3, 2021
ksolo
reviewed
Nov 4, 2021
ksolo
reviewed
Nov 4, 2021
jeremyschuurmans
force-pushed
the
jeremy/GITC-565/fix-twitter-handle-bug
branch
from
56b2324
to
ca970f8
Compare
ksolo
approved these changes
Nov 4, 2021
gdixon
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves an issue that occurred when full Twitter urls were pasted or entered into the Twitter handle fields on the new grant form.
Now when full Twitter urls are pasted or typed, they are formatted so that only the username is present on the form.
Screen.Recording.2021-11-03.at.2.30.49.PM.mov
Refers/Fixes
Testing
This PR includes a Cypress integration test.