fix: ensure that an invalid tezos txhash will not halt the sync command #9699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gdixon
requested review from
chibie,
frankchen07,
PixelantDesign and
thelostone-mc
as code owners
| @@ -46,7 +46,8 @@ def get_tezos_txn_status(fulfillment): | |||
|
|
|||
| tx_response = requests.get(f'{BASE_URL}/operations/{txnid}').json() | |||
|
|
|||
| if tx_response: | |||
| # a valid response will return a list whereas an invalid response will return a dict | |||
| if tx_response and isinstance(tx_response, list) and len(tx_response) > 0: | |||
There was a problem hiding this comment.
Could we switch this to ensure that txn_status is set to expired for this scenarios. ?
That way the txn isn't stuck in pending forever
There was a problem hiding this comment.
We can, are we sure that after a tx is made it will appear on this API instantly? If there is a delay then we risk setting non-propagated tx's to expired?
thelostone-mc
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR will ensure the sync command will continue even when presented with a malformed/missing (from chain) txhash
Refers/Fixes
Refers to: L2 issue (https://discord.com/channels/562828676480237578/910066042284429332/910686876329988147)
Testing
Tested locally