Jeremy/bug fix/grants explorer A-Z/Z-A sort does not take capitalization into account #9717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyschuurmans
requested review from
chibie,
frankchen07,
gdixon,
PixelantDesign and
thelostone-mc
as code owners
jeremyschuurmans
force-pushed
the
jeremy/bug-fix/grants-explorer-sort-does-not-take-capitalization-into-account
branch
from
89341ba
to
e4f1ae3
Compare
added 2 commits
November 23, 2021 07:25
jeremyschuurmans
referenced
this pull request
Nov 23, 2021
* add new labels and organize selections, disable keyboard input * add admin labels * add admin selections * refactor * remove some admin options (misunderstood requirements) * styling * sort by title, alphabetical and reverse alphabetical * refactor * refactor options to mimic optgroups, add more styling * display admin options if user is an admin * eslint fixes * refactor * refactor * fix broken admin options display * add test for admin options * fix typo * refactor specs * add a test for sorting functionality * refactor tests * fix broken mobile layout
thelostone-mc
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a bug present in the A-Z/Z-A sort on the grants explorer that breaks the sort if some grant titles are capitalized and others are not capitalized.
Also removes a deprecated sort option that was left in by mistake.
Refers/Fixes
Testing
Tested locally