-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of issue #1582 #1875
Conversation
Conflicts: GitCommands/Config/ConfigFile.cs
Conflicts: GitCommands/GitCommands.csproj
Conflicts: GitCommands/Settings/AppSettings.cs GitExtensionsTest GitUI/GitUICommands.cs
Submodule GitExtensionsTest: > 604b166 - Settings
Conflicts: GitCommands/Git/GitModule.cs GitExtensionsTest GitUI/CommandsDialogs/FormCheckoutBranch.cs
In "Revision links" settings: when creating a new "category" in Effective it will be stored in "Global for all repos" settings source. Is this intended? |
Yes, the idea is to set setting at the lowest possible level. |
"lowest" in the the sense of "with most impact"? |
"lowest" - the lowest level that has to be overriden to take effect on effective view |
There is exception for "Distributed with current repository" - it can't be set via effective view. |
so the more "low" the more "global" the setting is stored? EDIT: Or am I thinking in the wrong terms? |
Yes |
|
|
|
The checkboxes are fine like that. If all labels are aligned that way then it is clear where the checkbox's caption is. The search in is clear that you are choosing different places to search in. Enabled doesn't have a sub item. It is a setting of its own. |
For me it looks like a developer forgot to align this checkbox in your examples. |
I like this solution. :) (in the screenshot maybe the Name textbox width could be a bit larger for more elaborate names). |
Thanks, ok. |
Conflicts: GitExtensionsTest
Conflicts: GitUI/CommandsDialogs/FormSettings.Designer.cs GitUI/CommandsDialogs/SettingsDialog/Pages/GitExtensionsSettingsPage.cs GitUI/UserControls/RevisionGrid.cs
I think it is ready for tests and review.