-
-
Notifications
You must be signed in to change notification settings - Fork 850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Credit line bug #535
Credit line bug #535
Conversation
Thanks! Is it possible to figure out a test for this? |
@@ -21,7 +21,8 @@ def compound_changelog | |||
|
|||
log += File.read(options[:base]) if File.file?(options[:base]) | |||
|
|||
log += "\n\n\\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*" | |||
credit_line = "\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*" | |||
log += "\n\n\#{credit_line}" if log.include? credit_line == false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@olleolleolle do you know where the extra ''? Should it be "\n\n#{credit_line}"
?
@olleolleolle perhaps we can check there is only one |
For an integration test approach:
Then, as a follow-up (next) feature:
The second test would be about mending, repairing, fixing CHANGELOG.md files in the wild that have used earlier versions of the code, or are using the |
Fix issue #507. @olleolleolle please give a review. 😃