Add filenames to lex #4952
Merged
Add filenames to lex #4952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please let me know if there are any changes I need to make, to get this merged. |
Looks like you missed off adding the sample file you referenced 😄 |
|
Oh yes, and popularity looks good. |
|
thanks @lildude for the pointers. I fixed the link. |
|
@philass we still need a copy of the file added to the |
|
Sorry about that, I misunderstood what you said. Thanks for your patience! |
|
I think everything should be good now |
Alhadis
requested changes
Aug 30, 2020
Alhadis
approved these changes
Aug 31, 2020
sambacha
pushed a commit
to freight-trust/linguist
that referenced
this pull request
Sep 4, 2020
* Add filenames to lex * Add sample to Lex * Put Lexer.x in filenames * delete Lexer.x from languages.yml * Add Lexer.x to languages.yml * Fix filename ordering
Alhadis
added a commit
to file-icons/atom
that referenced
this pull request
Sep 17, 2020
Added: * CoffeeScript: `.coffee.md` (github-linguist/linguist#4957) * Lex: `lexer.x` (github-linguist/linguist#4952) * NGINX: `.nginx` (github-linguist/linguist#4965) * Ruby: `.simplecov` (github-linguist/linguist#4976)
exuanbo
added a commit
to exuanbo/file-icons-js
that referenced
this pull request
Oct 15, 2020
Added: * CoffeeScript: `.coffee.md` (github-linguist/linguist#4957) * Lex: `lexer.x` (github-linguist/linguist#4952) * NGINX: `.nginx` (github-linguist/linguist#4965) * Ruby: `.simplecov` (github-linguist/linguist#4976) file-icons/atom@56528ed
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of people name their Lex files Lexer.x or lexer.x. The issue is that the are incorrectly classifies with the
Logoslanguage. This PR aims to fix that.Description
Checklist:
The new extension is used in hundreds of repositories on GitHub.com
I have included a real-world usage sample for all extensions added in this PR:
Sample source(s):
Sample license(s): ISC License
I have included a change to the heuristics to distinguish my language from others using the same extension.