Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark .{1..9} as generic file-extensions #5059

Merged
merged 2 commits into from
Oct 26, 2020
Merged

Mark .{1..9} as generic file-extensions #5059

merged 2 commits into from
Oct 26, 2020

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Oct 22, 2020

Description

Successor of #4258, which makes use of Linguist's new generic extensions feature. To recap:

Many files on GitHub receive an incorrect classification of "Roff", simply because their filenames end in a numeric suffix:

Gemfile-3.0.3
GFDL-1.2
AFL-1.2
mkfontscale-1.1.1

Change-logs and version-numbers are particularly problematic examples of these. The ValveSoftware/steam-runtime, for instance, was shown as 72.8% Roff (until I fixed it), because of three license files with version-numbers. haskell-CI/haskell-ci was another example (until fixed). You can find those and more by checking GitHub's list of trending Roff repositories.

Checklist:

  • I am adding new or changing current functionality
    • I have added or updated the tests for the new or changed functionality.

@Alhadis Alhadis requested a review from lildude October 22, 2020 11:31
@Alhadis
Copy link
Collaborator Author

Alhadis commented Oct 22, 2020

@lildude Once this gets merged, and with your blessing, I'll follow-up with a PR to move the generic extensions list to its own file (lib/linguist/generic.yml).

@@ -0,0 +1,7 @@
菊千代
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice easter eggs here 😄

Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lildude
Copy link
Member

lildude commented Oct 26, 2020

Once this gets merged, and with your blessing, I'll follow-up with a PR to move the generic extensions list to its own file (lib/linguist/generic.yml).

Go for it. 🙇‍♂️

@Alhadis Alhadis merged commit 0b3814e into master Oct 26, 2020
@Alhadis Alhadis deleted the numeric-extensions branch October 26, 2020 10:32
@Alhadis
Copy link
Collaborator Author

Alhadis commented Oct 26, 2020

Done. 👍 See #5070.

@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants