Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Containerfile equivalency #5588

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

cevich
Copy link
Contributor

@cevich cevich commented Oct 7, 2021

Description

This file is exactly equivalent in every way and context. Exact same highlighting rules and handling should be provided for either name style.

Checklist:

  • I am associating a language with a new filename.

@cevich cevich requested a review from a team as a code owner October 7, 2021 15:16
lib/linguist/languages.yml Show resolved Hide resolved
@cevich
Copy link
Contributor Author

cevich commented Oct 7, 2021

We generally only add aliases when a language has multiple possible spellings, or is known by more than one name. Unless the name "Dockerfile" can be used interchangeably with "Containerfile" (and vice versa, regardless of context), I suggest leaving it out.

Actually yes, a Containerfile and a Dockerfile are 100% equivalent in every respect, and in every context. It's simply a de-branded name for the exact same underlying file-type AND contents.

In other words, the goal is for (in every context), these to be the same:

```Dockerfile
...blah...blah...blah...
```

and

```Containerfile
...blah...blah...blah...
```

Similarly when viewing the contents of a repository file or diff referencing either a Containerfile or a Dockerfile. They should look/feel/act exactly equivalent.

@cevich cevich changed the title Include Containerfile as an alias for Dockerfile Include Containerfile/.containerignore equivalencies Oct 7, 2021
@cevich
Copy link
Contributor Author

cevich commented Oct 7, 2021

Updates: Fixed up the description to match commit message + added similar equivalency for .containerfile.

@cevich
Copy link
Contributor Author

cevich commented Oct 7, 2021

Update: Added .containerfile to the list as well.

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
lib/linguist/languages.yml Outdated Show resolved Hide resolved
This file is exactly equivalent in every way and context.  Exact same
highlighting rules and handling should be provided for either name
style.
@cevich cevich changed the title Include Containerfile/.containerignore equivalencies Include Containerfile equivalency Oct 7, 2021
@cevich
Copy link
Contributor Author

cevich commented Oct 7, 2021

Update: Removed .containerfile and .containerignore references, updated commit message and PR title + description.

@cevich
Copy link
Contributor Author

cevich commented Oct 7, 2021

Thanks for your help and guidance @Alhadis

@lildude lildude merged commit 0f7b414 into github-linguist:master Oct 14, 2021
@lildude lildude linked an issue Oct 20, 2021 that may be closed by this pull request
Alhadis added a commit to file-icons/atom that referenced this pull request Dec 28, 2021
Added:
* Config, Python: `.flake8`       (github-linguist/linguist#5669)
* C++:            `.ixx`          (github-linguist/linguist#5680)
* Database:       `MANIFEST.MF`   (github-linguist/linguist#5505)
* Docker:         `Containerfile` (github-linguist/linguist#5588)
* GLSL:           `.r{chit,miss}` (github-linguist/linguist#5566)
* HTML:           `.hta`          (github-linguist/linguist#5533)
* Makefile:       `.makefile`     (github-linguist/linguist#5526)
* Readme:         `CITATION.cff`  (github-linguist/linguist#5577)
* Shell:          `.kshrc`        (github-linguist/linguist#5685)
* TypeScript:     `.cts`, `.mts`  (github-linguist/linguist#5696)
* XML:            `.hzp`          (github-linguist/linguist#5626)
kalkin added a commit to kalkin/file-expert that referenced this pull request Feb 15, 2022
According to the linguist discussion it looks to be some debranded name
replacement for Dockerfile. 🤷
@github-linguist github-linguist locked as resolved and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Containerfile syntax highlighting
3 participants