-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mts
and cts
TypeScript extensions
#5905
Add mts
and cts
TypeScript extensions
#5905
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't rename an existing sample. Please add another sample with the new extension instead. These samples are used to train the classifier for that particular extension so "removing" by renaming could affect the results.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nicolo-ribaudo To elaborate on @lildude's feedback, we'll two new samples, one for .cts
and another for .mts
. I recommend finding a genuine example instead of copy+pasting the contents of promisified_cp.cts
as promisified_cp.mts
.
So to recap, the contents of samples/TypeScript
should contain:
samples/TypeScript/cache.ts
+samples/TypeScript/promisified_cp.cts
+samples/TypeScript/{SOMETHING_NEW}.mts
Examples updated! |
Suggestion: I think we can showcase some |
I plan to make a new release next week. It'll be great if we can get |
Done! |
Description
TypeScript 4.7 introduced two new extensions:
.mts
and.cts
- https://devblogs.microsoft.com/typescript/announcing-typescript-4-7-beta/#new-file-extensionsThey are already widely used on GitHub, because they were initially announced for TypeScript 4.5 a few months ago.
Checklist:
.mts
I added https://github.com/nicolo-ribaudo/yarn-plugin-conditions/blob/main/sources/conditionParser.ts.cts
I added https://github.com/nicolo-ribaudo/yarn-plugin-babel-release-tool/blob/main/sources/utils/node.tsThese extensions are not used by any other language in
languages.yml