Add support for Huff

[sambacha]

♞ Huff

Huff is a low-level programming language designed for developing highly optimized smart contracts that run on the Ethereum Virtual Machine (EVM). Huff does not hide the inner workings of the EVM and instead exposes its programming stack to the developer for manual manipulation.

Huff does not hide the inner workings of the EVM and instead exposes its programming stack to the developer for manual manipulation.

• Huff Tutorials
• Huff Language Source
• Huff Website, huff.sh
• Huff Twitter
• Huff Discord

Checklist:

• I am adding a new language.

  • The extension of the new language is used in hundreds of repositories on GitHub.com.

    • Search results for each extension:
      • https://github.com/search?type=code&q=NOT+is%3Afork+path%3A*.huff

  • I have included a real-world usage sample for all extensions added in this PR:

    • Sample source(s):
      • https://github.com/sambacha/huff-ghlang/blob/master/samples/ERC20.huff
    • Sample license(s): https://github.com/sambacha/huff-ghlang/blob/master/LICENSE.txt

  • I have included a syntax highlighting grammar: https://github.com/sambacha/huff-ghlang

  • I have added a color

    • Hex value: #707598 https://www.color-hex.com/color/707598
    • Rationale: Taken from official website accent colours: https://github.com/huff-language/huff-web/blob/829b10075a11c32c4628530fe1f2f858d9184e33/src/definitions/styled-components/common.ts#L13C14-L13C20

  • I have updated the heuristics to distinguish my language from others using the same extension.

[sambacha]

Unsure of why 3.2 test failing

[lildude]

Unsure of why 3.2 test failing

Capitalisation

[lildude]

You can fix the tests by capitalising the h in the samples directory name: samples/huff/ -> samples/Huff/

[sambacha]

You can fix the tests by capitalising the h in the samples directory name: samples/huff/ -> samples/Huff/

Subtle overlook on my part, apologies and thank you for pointing that out!

Is their insufficient usage of this language to be considered for inclusion right now (re: label of pending popularity)?

Thanks for the feedback, appreciate it.

[lildude]

Is their insufficient usage of this language to be considered for inclusion right now (re: label of pending popularity)?

Yup. Usage of all extensions being added needs to meet usage requirements so you might want to consider removing the .hf extension for now as it appears to be significantly less used than .huff from a quick look. Users can use an override once this PR is merged and deployed.

I've used the search link you've provided in the template (I'm AFK on mobile only ATM) so if you can improve that to match more files, then go for it.

[sambacha]

Is their insufficient usage of this language to be considered for inclusion right now (re: label of pending popularity)?

Yup. Usage of all extensions being added needs to meet usage requirements so you might want to consider removing the .hf extension for now as it appears to be significantly less used than .huff from a quick look. Users can use an override once this PR is merged and deployed.

I've used the search link you've provided in the template (I'm AFK on mobile only ATM) so if you can improve that to match more files, then go for it.

Thank you for the clarification. One would think that file extensions would be a transitive relational property, I removed the short hand .hf per your suggestion.

Thanks for your patience, much obliged!

[sambacha]

Resolved the last remaining issue, an overlook on my part, apologies!

After looking at the example files again, I have a question:

Would creating an example piece of code (in our case a contract) that is not meant to work (or be a good example). Rather it should be written for the purposes of demonstrating good syntax highlighting by the lexer, even if otherwise hazardous/not idiomatic of the language per se?

I encountered this issue while trying to fix the Nix grammar that linguist was using before tree-sitter support was made available.

Example pre tree-sitter the grammar was not able to correctly highlight this as valid nix.

[lildude]

Would creating an example piece of code (in our case a contract) that is not meant to work (or be a good example). Rather it should be written for the purposes of demonstrating good syntax highlighting by the lexer, even if otherwise hazardous/not idiomatic of the language per se?

Such a contrived example would only really be useful for the grammar, not linguist. We need real world samples as they're used to train the classifier, not validate syntax highlighting, so a contrived example is more likely to lead to misidentification.

[sambacha]

Is their insufficient usage of this language to be considered for inclusion right now (re: label of pending popularity)?

Yup. Usage of all extensions being added needs to meet usage requirements so you might want to consider removing the .hf extension for now as it appears to be significantly less used than .huff from a quick look. Users can use an override once this PR is merged and deployed.

I've used the search link you've provided in the template (I'm AFK on mobile only ATM) so if you can improve that to match more files, then go for it.

There are now over 1.1k file (164 ms) results found using the query: https://github.com/search?q=%28path%3A*.huff+OR+path%3A*.Huff%29&type=code

Appreciate the patience @lildude - have fixed all outstanding issues, please let me know how this can move forward. Cheers!

[sambacha]

Circling back around @lildude @Alhadis - all the requests per your last review have been addressed.

[lildude]

From a quick glance, things are looking good now though usage is still too low when we exclude forks and the huff-language user. I'll keep reviewing the usage with each release.

Issues resolved

[erhant]

popularity about to rise with the upcoming Huff hackathon! :)

[sambacha]

From a quick glance, things are looking good now though usage is still too low when we exclude forks and the huff-language user. I'll keep reviewing the usage with each release.

Thanks for the clarification, I appreciate the follow-up. Will circle back around and check as well, we are at 932 reported findings per your query. 

Cheers, 

• Sam

[erhant]

From a quick glance, things are looking good now though usage is still too low when we exclude forks and the huff-language user. I'll keep reviewing the usage with each release.

The query above now returns over 1.2k files! Plus, Huff icon just got merged to a widely-used icon theme material-extensions/vscode-material-icon-theme#2190

[sambacha]

May we get a review @lildude - we should be good to go!

Please let me know if you want any additional changes or clean up of git commits etc.

Thanks!

[lildude]

Reviews of all pending popularity PRs takes place when I'm preparing for the next release. This will be reviewed again then.

[sambacha]

Reviews of all pending popularity PRs takes place when I'm preparing for the next release. This will be reviewed again then.

When do you plan on preparing a next release? I ask because I was going to submit a fix for the TOML grammar that is being used, which would involve replacing the current one in use as its not actively maintained.

Thanks for the follow up, as linguist is a production dependency for GitHub I appreciate the care taken!

[lildude]

I need to do it before my colleagues start preparing the next release of Enterprise Server which starts around the middle of the month, so it'll probably be sometime next week or early the week after.

[sambacha]

I need to do it before my colleagues start preparing the next release of Enterprise Server which starts around the middle of the month, so it'll probably be sometime next week or early the week after.

Thanks for the update, will be sure to keep an eye out in case any changes/updates need to be made.

Cheers!

[sambacha]

I need to do it before my colleagues start preparing the next release of Enterprise Server which starts around the middle of the month, so it'll probably be sometime next week or early the week after.

hey @lildude just circling back seeing if there is anything on my end needed to get this sorted!

Thanks again!

[lildude]

As previously stated, nothing more is needed on this PR and I review popularity with each release. Our requirements still weren't met when I reviewed for the last release. I do not comment each time as it's too time consuming, so no news is good news. There's also no need to keep merging in master unless the UI indicates there is a conflict.

[sambacha]

As previously stated, nothing more is needed on this PR and I review popularity with each release. Our requirements still weren't met when I reviewed for the last release. I do not comment each time as it's too time consuming, so no news is good news. There's also no need to keep merging in master unless the UI indicates there is a conflict.

Thanks, I only ask because I see a release was made on May 2nd, so just making sure we do not get left behind!

[sambacha]

As previously stated, nothing more is needed on this PR and I review popularity with each release. Our requirements still weren't met when I reviewed for the last release. I do not comment each time as it's too time consuming, so no news is good news. There's also no need to keep merging in master unless the UI indicates there is a conflict.

Just circling back on this PR, as was updating #6988 for adding RFC 5545/iCAL support