-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace Open Policy Agent grammar #6575
Replace Open Policy Agent grammar #6575
Conversation
Signed-off-by: Ashutosh Narkar <anarkar4387@gmail.com>
Why the change? The original appears to be a fork of the new with added functionality. We don't want to lose functionality when changing. /cc @tsandall as the owner of the fork and current grammar. |
We should not lose functionality if we switch. The new repo is actively maintained and the latest grammar updates will be pushed to it. cc @tsandall |
👋 yep, this should point at github.com/open-policy-agent/vscode-opa rather than my fork. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An updated copy of the license file should have been downloaded when you ran script/add-grammar --replace
as detailed in the docs. Please add this updated cached license file to this PR.
If you can't find it, you can run: bundle exec licensed cache -c vendor/licenses/config.yml
I ran
|
Fixed it. Seems when the grammar was replaced it didn't pull the latest version. I updated the grammar with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
Description
This PR updates the source of the Open Policy Agent grammar.
Checklist: