-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace the WDL language grammar #6972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not change the samples. They are used to train the classifier and there will almost always be files on GitHub using older syntax.
If you want to help detect newer syntax, add more samples.
7fa3f61
to
5ef2a5a
Compare
Okay, I've reverted those samples and added a new one! Let me know what you think, @lildude. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also replace your sample with a real world example and update the template to state where it comes from and the license of the sample.
29adda4
to
a247e63
Compare
This should be addressed: I added a new, real-world example and also added the license to the template for the PR and the header of that sample. |
The test failure suggests you might not have used the documented method of replacing the grammar as the script sorts the submodules. Please use the script as documented. You can replace the grammar with itself using the script. |
a247e63
to
d638f38
Compare
d638f38
to
ff00470
Compare
Okay, I think I've resolved this now—I had used the script, but had done some spelunking on the codebase beforehand to try to understand how it worked (in unstaged changes). I checked out a fresh version of the repo, applied my changes, and then got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Note: this PR will not be merged until close to when the next release is made. See here for more details.
This PR updates support for the WDL to the latest version (v1.2).
Description
We've written the grammar from scratch to be compliant with the latest version of WDL—currently, the grammar used in linguist is around 6 years old (and represents a very old version of WDL).
A list of some (but not all) improvements being:
requirements
).command
blocks.Checklist:
(From the I am adding a new language of the template. section, as I'm adding a new example)
fq.wdl