Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This Pull Request adds support for PunkScript in Linguist, including usage examples. #7141

Closed
wants to merge 3 commits into from

Conversation

AndersonShelby
Copy link

@AndersonShelby AndersonShelby commented Nov 27, 2024

Description

Checklist:

  • I am adding a new extension to a language.

    • The new extension is used in hundreds of repositories on GitHub.com
    • I have included a real-world usage sample for all extensions added in this PR:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am adding a new language.

  • I am fixing a misclassified language

    • I have included a new sample for the misclassified language:
      • Sample source(s):
        • [URL to each sample source, if applicable]
      • Sample license(s):
    • I have included a change to the heuristics to distinguish my language from others using the same extension.
  • I am changing the source of a syntax highlighting grammar

    • Old: [URL to grammar repo]
    • New: [URL to grammar repo]
  • I am updating a grammar submodule

  • I am adding new or changing current functionality

    • I have added or updated the tests for the new or changed functionality.
  • I am changing the color associated with a language

    • I have obtained agreement from the wider language community on this color change.
      • [URL to public discussion]
      • [Optional: URL to official branding guidelines for the language]

@AndersonShelby AndersonShelby requested a review from a team as a code owner November 27, 2024 18:37
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the instructions in the CONTRIBUTING.md file and translate all text into English.

@AndersonShelby AndersonShelby changed the title Adiciona suporte ao PunkScript no Linguist e exemplos de uso This Pull Request adds support for PunkScript in Linguist, including usage examples. Nov 27, 2024
@AndersonShelby
Copy link
Author

Okay, I've translated all the texts including comments in scripts. Is there anything else to check?

@lildude
Copy link
Member

lildude commented Nov 28, 2024

Okay, I've translated all the texts including comments in scripts. Is there anything else to check?

Yup.

  1. Follow all of the instructions in CONTRIBUTING.md for adding a new language (you've missed a few)
  2. Actually add the TextMate compatible grammar if you want syntax highlighting
  3. Complete filling in the PR template

That said on further investigation, this appears to be a very new language with absolutely zero references to it on GitHub or even Google. I see you've referenced a private repo which suggests this might be a hobby project. We have usage requirements for adding a new language which means we don't add support for very new and hobby languages. Accordingly I'm closing this PR. Feel free to create a new PR once your language meets our usage requirements.

@lildude lildude closed this Nov 28, 2024
@AndersonShelby
Copy link
Author

Okay, I'll do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants