Fixing wrong usage of last's command exit code and some cleaning... #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeke
reviewed
Sep 18, 2017
|
|
||
| # Find current directory relative to .git parent | ||
| full_path=$(pwd) | ||
| git_base_path=$(cd ./$(git rev-parse --show-cdup); pwd) | ||
| relative_path=${full_path#$git_base_path} # remove leading git_base_path from working directory | ||
|
|
||
| # If filename argument is present, append it | ||
| if [ "$1" ]; then | ||
| relative_path="$relative_path/$1" | ||
| if [[ ! -z "${1}" ]]; then |
zeke
reviewed
Sep 18, 2017
| open=$opener; | ||
| break; | ||
| fi | ||
| if command -v ${opener}; then |
There was a problem hiding this comment.
why the extra indentation here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error here:
$? is reading the status of the last command, which is echo, so it will alwats be 0 ...
This is a good alternative: