-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix README typo about ignoring issues #129
Conversation
It said specified issues, now it's one of the specified labels.
@datitisev not sure why testing is failing. I'll check and update. Thanks for contributing 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@datitisev could you please update this too?
@alexcanessa Done! Travis seems to be failing because of a missing token for the coverage. |
@datitisev ok, that's the reason: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions I'll see what I can change in terms of different tests for different forks. |
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
===========================================
- Coverage 85.71% 39.68% -46.04%
===========================================
Files 7 7
Lines 315 315
===========================================
- Hits 270 125 -145
- Misses 45 190 +145
Continue to review full report at Codecov.
|
Lmao that codecov report. No problem! |
@all-contributors please add @datitisev for docs |
I've put up a pull request to add @datitisev! 🎉 |
It said specified issues, now it's "one of the specified labels."