Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix README typo about ignoring issues #129

Merged
merged 5 commits into from
Jan 16, 2018
Merged

Fix README typo about ignoring issues #129

merged 5 commits into from
Jan 16, 2018

Conversation

dsevillamartin
Copy link
Contributor

@dsevillamartin dsevillamartin commented Jan 16, 2018

It said specified issues, now it's "one of the specified labels."

It said specified issues, now it's one of the specified labels.
@alexcanessa
Copy link
Member

@datitisev not sure why testing is failing. I'll check and update.

Thanks for contributing 👍

Copy link
Member

@alexcanessa alexcanessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsevillamartin
Copy link
Contributor Author

@alexcanessa Done!

Travis seems to be failing because of a missing token for the coverage.

@alexcanessa
Copy link
Member

@datitisev ok, that's the reason: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions

I'll see what I can change in terms of different tests for different forks.

@alexcanessa alexcanessa merged commit 2c8888c into github-tools:master Jan 16, 2018
@codecov-io
Copy link

codecov-io commented Jan 16, 2018

Codecov Report

Merging #129 into master will decrease coverage by 46.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #129       +/-   ##
===========================================
- Coverage   85.71%   39.68%   -46.04%     
===========================================
  Files           7        7               
  Lines         315      315               
===========================================
- Hits          270      125      -145     
- Misses         45      190      +145
Impacted Files Coverage Δ
lib/src/Gren.js 5.94% <0%> (-77.84%) ⬇️
lib/src/GitHubInfo.js 80.95% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9c87c8...5a07b04. Read the comment docs.

@dsevillamartin dsevillamartin deleted the patch-1 branch January 16, 2018 16:29
@dsevillamartin
Copy link
Contributor Author

Lmao that codecov report. No problem!

@alexcanessa
Copy link
Member

@all-contributors please add @datitisev for docs

@allcontributors
Copy link
Contributor

@alexcanessa

I've put up a pull request to add @datitisev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants