Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to set limit in options for tags. Fixes #144 #148

Merged
merged 6 commits into from
Apr 19, 2018

Conversation

phun-ky
Copy link

@phun-ky phun-ky commented Mar 8, 2018

No description provided.

@codecov-io
Copy link

codecov-io commented Mar 8, 2018

Codecov Report

Merging #148 into master will decrease coverage by 47.14%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #148       +/-   ##
===========================================
- Coverage   84.13%   36.98%   -47.15%     
===========================================
  Files           7        7               
  Lines         334      338        +4     
===========================================
- Hits          281      125      -156     
- Misses         53      213      +160
Impacted Files Coverage Δ
lib/_options.js 71.42% <ø> (ø) ⬆️
lib/src/Gren.js 5.28% <0%> (-76.09%) ⬇️
lib/src/GitHubInfo.js 80.95% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf6e7c4...973d3f9. Read the comment docs.

Copy link
Member

@alexcanessa alexcanessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phun-ky please add it to the options file as will be needed by the docs and the command.

@alexcanessa
Copy link
Member

@phun-ky any updates on this one? Would really like to merge this 👍

@phun-ky
Copy link
Author

phun-ky commented Mar 27, 2018

@alexcanessa oh, I totally forgot this! Will try to squeeze it in tonight :) (CET)

@phun-ky
Copy link
Author

phun-ky commented Apr 17, 2018

@alexcanessa sorry for the slow-mo here :(

Copy link
Member

@alexcanessa alexcanessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happened to all the " 😄

@phun-ky
Copy link
Author

phun-ky commented Apr 19, 2018

@alexcanessa seems that my prettierconfig was activated there.. bah! will try to fix it

@alexcanessa
Copy link
Member

@phun-ky should be easy to fix as you run gulp it should run the eslint configuration.

@phun-ky
Copy link
Author

phun-ky commented Apr 19, 2018

@alexcanessa done

@alexcanessa alexcanessa merged commit 9ff8e2a into github-tools:master Apr 19, 2018
@alexcanessa
Copy link
Member

Nice!

gren has to be upgraded a bit in terms of stack TBH. e.g. hooks with npm tasks instead of gulp, Prettier with eslint (with no configuration) etc.

@alexcanessa
Copy link
Member

@all-contributors add code for @phun-ky

@allcontributors
Copy link
Contributor

@alexcanessa

I've put up a pull request to add @code! 🎉

@alexcanessa
Copy link
Member

Oops, the other way around lol

@all-contributors add @phun-ky for code

@allcontributors
Copy link
Contributor

@alexcanessa

I've put up a pull request to add @phun-ky! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants