Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change gren to take only pull requests that have been merged #154

Merged

Conversation

wellDan28
Copy link
Contributor

Close #133

Until Prs was retrieve using the List issues endpoint endpoint in the github api.
The problem with this endpoint it doesn't have the information about if the prs were merged. This information is vital because Gren should take only merged pr.

To solve this issue, the List issues endpoint was replace by the List pull request endpoint

@codecov-io
Copy link

codecov-io commented Apr 2, 2018

Codecov Report

Merging #154 into master will decrease coverage by 48.64%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #154       +/-   ##
===========================================
- Coverage   86.06%   37.42%   -48.65%     
===========================================
  Files           7        7               
  Lines         323      334       +11     
===========================================
- Hits          278      125      -153     
- Misses         45      209      +164
Impacted Files Coverage Δ
lib/src/Gren.js 5.39% <0%> (-79.07%) ⬇️
lib/src/GitHubInfo.js 80.95% <0%> (-4.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78786b3...4a368b0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants