Always specify ssh port when using ghe-ssh #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user doesn't specify a port, backup-utils makes assumptions based on the successful connection test at https://github.com/github/backup-utils/blob/master/bin/ghe-host-check#L27
The problem with this is if a user adds an entry to their
${HOME}/.ssh/config
similar to:... this test thinks the connection was made on port 22, when it was actually on port 122, and the restore fails as follows:
... forcing people to explicitly specify a port in their
backup.config
or in the hostname they pass as an argument.This PR removes this assumption and forces the explicit setting of a port in all SSH commands thus catching this scenario.
As GitHub Enterprise only accepts connections on port 22 and 122 with no option of customising this, I think this is a safe thing to do. Even if someone does change this to some obscure port in the future, the processing of the port passed in via the argument or config continues to work.