Use the new ghe-negotiate-version script #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dbussink just cleaned up the metadata files (the version number used to be specified in 4 different places), and this wasn't the file that he decided to keep. This needs to be updated or we can't recognize VMs running the next version of GHE.
Make use of the newly added ghe-negotiate-version script to push more of the version checking logic to the appliance.
ionice exits 1 if the command given to it cannot be found but in this case we're running /bin/sh which will always be found. The 127 exit from /bin/sh is propagated properly when the ghe-negotiate-version program isn't found.
This reverts commit 28050ab. I'm not sure we can rely on this new file location being present on versions pre-2.0 so reverting back. The ghe-negotiate-version program should be available on anything >= 2.1 and the chef_metadata.json should be available on anything < 2.1.
I'm weary of relying on git-describe and all the different paths here. Just keeping the file versioned manually is a lot simpler for now and basing the version off of tags doesn't buy us a lot.
|
Looks good to me 👍 |
rtomayko
added a commit
that referenced
this pull request
Jan 15, 2015
Use the new ghe-negotiate-version script
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes use of the new
ghe-negotiate-versionscript to ship in GHE v2.1. The idea is to push more of the version checking logic to the appliance. This will eventually let us get rid backup-utils logic that assumes hard-coded version file paths and gives the appliance a chance to require a minimum backup-utils version in a controlled way.Original patch by @MikeMcQuaid in our (now defunct) internal backup-utils repository.