Merge pull request #175 from github/code-cleanup

Code cleanup

src/functions/environment-targets.js

@@ -1,5 +1,6 @@
 import * as core from '@actions/core'
 import dedent from 'dedent-js'
+import {checkInput} from './check-input'
 import {actionStatus} from './action-status'
 import {LOCK_METADATA} from './lock-metadata'
 
@@ -270,7 +271,7 @@ async function findEnvironmentUrl(environment, environment_urls) {
   // The structure: "<environment1>|<url1>,<environment2>|<url2>,etc"
 
   // If the environment URLs are empty, just return an empty string
-  if (environment_urls === null || environment_urls.trim() === '') {
+  if ((await checkInput(environment_urls)) === null) {
     return null
   }
 

src/main.js

@@ -25,10 +25,10 @@ import {stringToArray} from './functions/string-to-array'
 export async function run() {
   try {
     // Get the inputs for the branch-deploy Action
-    const trigger = core.getInput('trigger')
-    const reaction = core.getInput('reaction')
     const token = core.getInput('github_token', {required: true})
     var environment = core.getInput('environment', {required: true})
+    const trigger = core.getInput('trigger', {required: true})
+    const reaction = core.getInput('reaction')
     const stable_branch = core.getInput('stable_branch')
     const noop_trigger = core.getInput('noop_trigger')
     const lock_trigger = core.getInput('lock_trigger')
@@ -49,6 +49,7 @@ export async function run() {
     const admins = core.getInput('admins')
     const environment_urls = core.getInput('environment_urls')
     const param_separator = core.getInput('param_separator')
+    const permissions = core.getInput('permissions')
 
     // Create an octokit client
     const octokit = github.getOctokit(token)
@@ -177,7 +178,7 @@ export async function run() {
         skipReviews: skipReviews,
         draft_permitted_targets,
         admins: admins,
-        permissions: await stringToArray(core.getInput('permissions'))
+        permissions: await stringToArray(permissions)
       }
 
       // Run the help command and exit