Show muted colors for conditions in legend #1257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlinksva
approved these changes
Nov 25, 2024
mlinksva
reviewed
Nov 25, 2024
| @@ -40,14 +40,15 @@ class Choosealicense | |||
| # Dynamically add annotations as title attribute to rule list items | |||
| for ruletype, rules of window.annotations | |||
| for rule in rules | |||
| licenseLiElement = $(".license-#{ruletype} .#{rule["tag"]}") | |||
| # Only select license elements in table, not legend | |||
| licenseLiElement = $("td.license-#{ruletype} .#{rule["tag"]}") | |||
There was a problem hiding this comment.
Belatedly noticing, I think this may have removed the tooltip from https://choosealicense.com/licenses/ and individual license pages.
There was a problem hiding this comment.
Good catch! Fixed in #1259
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #1256.
This PR adds the same classes for the different license conditions so that the colours match what is shown in the table.