Apply suggestions from code review

Co-authored-by: Henry Mercer <henry.mercer@me.com>
github · Oct 25, 2023 · e3f5f83 · e3f5f83
1 parent 838be48
commit e3f5f83
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/pr-checks/checks/cpp-deptrace-disabled.yml b/pr-checks/checks/cpp-deptrace-disabled.yml
@@ -1,7 +1,7 @@
-name: "Cpp: disabling autoinstalling dependencies"
+name: "C/C++: disabling autoinstalling dependencies (Linux)"
 description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly disabled works"
 operatingSystems: ["ubuntu"]
-versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs
+versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with CLIs < 2.15.0
 env:
   DOTNET_GENERATE_ASPNET_CERTIFICATE: "false"
 steps:
@@ -21,6 +21,6 @@ steps:
   - shell: bash
     run: |
       if ls /usr/bin/errno; then
-        echo "Did autoinstall errno, and it should not have"
+        echo "C/C++ autobuild installed errno, but it should not have since auto-install dependencies is disabled."
         exit 1
       fi
diff --git a/pr-checks/checks/cpp-deptrace-enabled-on-macos.yml b/pr-checks/checks/cpp-deptrace-enabled-on-macos.yml
@@ -1,5 +1,5 @@
-name: "Cpp: disabling autoinstalling dependencies"
-description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly disabled works"
+name: "C/C++: autoinstalling dependencies is skipped (macOS)"
+description: "Checks that running C/C++ autobuild with autoinstalling dependencies explicitly enabled is a no-op on macOS"
 operatingSystems: ["macos"]
 versions: ["nightly-latest"]  # This is not released yet, will come with 2.15.2
 env:

diff --git a/pr-checks/checks/cpp-deptrace-enabled.yml b/pr-checks/checks/cpp-deptrace-enabled.yml
@@ -1,7 +1,7 @@
-name: "Cpp: enabling autoinstalling dependencies"
+name: "C/C++: autoinstalling dependencies (Linux)"
 description: "Checks that running C/C++ autobuild with autoinstalling dependencies works"
 operatingSystems: ["ubuntu"]
-versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with old CLIs
+versions: ["latest", "default", "nightly-latest"] # This feature is not compatible with CLIs < 2.15.0
 env:
   DOTNET_GENERATE_ASPNET_CERTIFICATE: "false"
 steps: