Revert usage of --codescanning-config flag
#1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backs out the change from #957 and most of the subsequent fix to it in #999 (although I've left some code in place to make it easier to do this again in future).
A customer has run into another issue with this change: the Action allows specifying additional queries directly in the workflow file rather than in the config file, but the new code path does not respect these additional queries. The proper fix here, I think, is that we should have the Action inject these additional queries into the config file we pass to the CLI, like we are already doing for the ATM queries. In the interest of caution, however, I think we should revert this change temporarily while we get a stable version into GHES 3.5, then add it in with the aforementioned fix and a new test to cover this case once code freeze has passed.
Merge / deployment checklist