Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running tests on Node 18.8 #1231

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

henrymercer
Copy link
Contributor

This PR fixes errors like this:

  TypeError: Cannot destructure property 'payload' of 'sourceMap' as it is null.

  › file://node_modules/mem/dist/index.js:42:27
  › file://node_modules/mem/dist/index.js:42:27
  › Object.<anonymous> (src/analyze-action-post-helper.test.ts:12:5)

  ✖ src/analyze-action-post-helper.test.ts exited with a non-zero exit code: 1

when running tests on Node 18.8. The fix is simple: update ava to v4.3.3. This version of ava adds compatibility with Node 18.8.

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

The [release notes](https://github.com/avajs/ava/releases/tag/v4.3.3)
mention compatibility with Node 18.8.
@henrymercer henrymercer requested a review from a team as a code owner September 2, 2022 17:16
Copy link
Contributor

@adityasharad adityasharad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable. I had hoped Dependency Review would show me the other dependencies that were updated in the lockfile as a result, but it's clear what you're primarily changing here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants