Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python-setup: Add support for Poetry 1.2 #1258

Merged
merged 4 commits into from
Sep 21, 2022
Merged

python-setup: Add support for Poetry 1.2 #1258

merged 4 commits into from
Sep 21, 2022

Conversation

RasmusWL
Copy link
Member

@RasmusWL RasmusWL commented Sep 19, 2022 •
edited by henrymercer
Loading

Fixes #1241

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@RasmusWL RasmusWL marked this pull request as ready for review September 19, 2022 11:16
@RasmusWL RasmusWL requested review from a team as code owners September 19, 2022 11:16
tausbn
tausbn previously approved these changes Sep 19, 2022
View reviewed changes
Copy link

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. 👍

python-setup/auto_install_packages.py Outdated Show resolved Hide resolved
henrymercer
henrymercer previously approved these changes Sep 20, 2022
View reviewed changes
Copy link
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small tweak to the changelog note and an optional comment.

CHANGELOG.md Outdated Show resolved Hide resolved
python-setup/auto_install_packages.py Outdated Show resolved Hide resolved
@RasmusWL @henrymercer
Update CHANGELOG.md
1309aaf 
Co-authored-by: Henry Mercer <henrymercer@github.com>
@RasmusWL RasmusWL dismissed stale reviews from henrymercer and tausbn via 1309aaf September 20, 2022 13:43
henrymercer
henrymercer previously approved these changes Sep 20, 2022
View reviewed changes
python-setup/auto_install_packages.py Outdated Show resolved Hide resolved
@RasmusWL RasmusWL merged commit 417059f into main Sep 21, 2022
@RasmusWL RasmusWL deleted the rasmuswl/poetry-v1.2 branch September 21, 2022 12:03
This was referenced Sep 21, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@henrymercer henrymercer henrymercer approved these changes

@tausbn tausbn tausbn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Poetry 1.2 support
3 participants
@RasmusWL @tausbn @henrymercer